[UR] Fix size confusion for several device property queries #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al42and
force-pushed
the
test-fix-sub-group-size-info
branch
from
92877bc
to
ab0d244
Compare
kbenzie
changed the title
kbenzie
approved these changes
Jun 10, 2024
The UR specification for the UR_DEVICE_INFO_SUB_GROUP_SIZES_INTEL device query is specified to use `uint32_t[]` whereas the SYCL specification defines the `sub_group_sizes` query as `std::vector<size_t>`. This patch adds a translation between `uint32_t[]` and `std::vector<size_t>` in order to correctly propagate results.
kbenzie
changed the title
sergey-semenov
approved these changes
Jun 11, 2024
|
@intel/llvm-gatekeepers please merge |
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
) For testing oneapi-src/unified-runtime#1282 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing oneapi-src/unified-runtime#1282